Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvrpcpb: change Context.stale_read from bool to enum #1274

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

kvrpcpb: change Context.stale_read from bool to enum #1274

wants to merge 6 commits into from

Conversation

crazycs520
Copy link

@crazycs520
init
ecad133 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
build
fe98d0c 
Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the size/XXL label Oct 23, 2024
@ti-chi-bot ti-chi-bot bot requested a review from shihongzhi October 23, 2024 14:25
@crazycs520
Copy link
Author

@MyonKeminta @cfzjywxk PTAL

@cfzjywxk cfzjywxk requested review from cfzjywxk, zyguan, MyonKeminta, ekexium and you06 and removed request for shihongzhi October 23, 2024 14:47
ekexium
ekexium reviewed Oct 23, 2024
View reviewed changes
proto/kvrpcpb.proto Outdated Show resolved Hide resolved
cfzjywxk
cfzjywxk approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot removed the approved label Oct 23, 2024
@crazycs520
refine
b192422 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
build
2c61b7f 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
refine
0c2ab42 
Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta
Once this PR has been reviewed and has the lgtm label, please assign cfzjywxk, zhangjinpeng87 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk]
  • proto/OWNERS [cfzjywxk]

    Need more approvers for rest parts.

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-23 14:49:46.226912935 +0000 UTC m=+448986.923703563: ☑️ agreed by cfzjywxk.
  • 2024-10-23 16:47:34.476555188 +0000 UTC m=+456055.173345794: ☑️ agreed by MyonKeminta.

@cfzjywxk cfzjywxk added the DNM Do Not Merge label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium left review comments

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@zyguan zyguan Awaiting requested review from zyguan

@you06 you06 Awaiting requested review from you06

Assignees
No one assigned
Labels
DNM Do Not Merge lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @cfzjywxk @MyonKeminta @ekexium