Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvrpcpb: add key errors to split region response #1248

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented May 29, 2024

Reserved for file based transaction. Ref: #1233

@ti-chi-bot ti-chi-bot bot requested review from cfzjywxk and overvenus May 29, 2024 12:36
@ti-chi-bot ti-chi-bot bot added the size/XXL label May 29, 2024
@pingyu pingyu marked this pull request as draft May 29, 2024 12:37
@pingyu pingyu marked this pull request as ready for review June 12, 2024 02:59
@ti-chi-bot ti-chi-bot bot requested a review from YuJuncen June 12, 2024 02:59
Copy link

ti-chi-bot bot commented Jun 12, 2024

@coocood: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, coocood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-12 07:44:12.086503236 +0000 UTC m=+537006.139815159: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2024
@pingyu pingyu merged commit bca367d into pingcap:master Jun 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants