-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raft_serverpb: add new ExtraMessage types for the snapshot gen precheck process #1245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM, let's hold this PR until the TiKV side implements and tests the functionality. |
Signed-off-by: Bisheng Huang <[email protected]>
Signed-off-by: Bisheng Huang <[email protected]>
…ck process This commit adds two new new ExtraMessage types that are part of the snapshot gen precheck process. Before a leader generates a snapshot, it sends a precheck request to the target follower. The follower responds with a boolean value indicating whether the check succeeds. Signed-off-by: Bisheng Huang <[email protected]>
a4779ca
to
3272933
Compare
Signed-off-by: Bisheng Huang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Bisheng Huang <[email protected]>
/merge |
/lgtm |
@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@overvenus: Your lgtm message is repeated, so it is ignored. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
Related issue: tikv/tikv#15972
This commit adds two new new ExtraMessage types that are part of the snapshot
gen precheck process: Before a leader generates a snapshot, it sends a precheck
request to the target follower. The follower responds with a boolean value
indicating whether the check succeeds.