Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft_serverpb: add new ExtraMessage types for the snapshot gen precheck process #1245

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

hbisheng
Copy link
Contributor

Related issue: tikv/tikv#15972

This commit adds two new new ExtraMessage types that are part of the snapshot
gen precheck process: Before a leader generates a snapshot, it sends a precheck
request to the target follower. The follower responds with a boolean value
indicating whether the check succeeds.

@ti-chi-bot ti-chi-bot bot requested review from overvenus and tonyxuqqi May 15, 2024 08:51
@CLAassistant
Copy link

CLAassistant commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS label May 15, 2024
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 15, 2024

@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@overvenus
Copy link
Member

LGTM, let's hold this PR until the TiKV side implements and tests the functionality.

hbisheng added 3 commits May 21, 2024 13:30
Signed-off-by: Bisheng Huang <[email protected]>
…ck process

This commit adds two new new ExtraMessage types that are part of the snapshot
gen precheck process.

Before a leader generates a snapshot, it sends a precheck request to the target
follower. The follower responds with a boolean value indicating whether the
check succeeds.

Signed-off-by: Bisheng Huang <[email protected]>
@hbisheng hbisheng force-pushed the snapshot-send-reserve branch from a4779ca to 3272933 Compare May 21, 2024 05:31
Signed-off-by: Bisheng Huang <[email protected]>
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jun 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-06 11:56:11.510646017 +0000 UTC m=+33725.563957942: ☑️ agreed by overvenus.

Signed-off-by: Bisheng Huang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Jun 7, 2024
@Connor1996
Copy link
Member

/merge

@Connor1996
Copy link
Member

/lgtm

Copy link

ti-chi-bot bot commented Jun 7, 2024

@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@overvenus
Copy link
Member

/lgtm

Copy link

ti-chi-bot bot commented Jun 7, 2024

@overvenus: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@overvenus
Copy link
Member

/approve

Copy link

ti-chi-bot bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@overvenus
Copy link
Member

/merge

@overvenus overvenus added the lgtm label Jun 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0ad602a into pingcap:master Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants