Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiproxy: fix broken links #2500

Merged
merged 1 commit into from
Jan 22, 2024
Merged

tiproxy: fix broken links #2500

merged 1 commit into from
Jan 22, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jan 22, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Close #2498

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug. labels Jan 22, 2024
@Oreoxmt Oreoxmt requested a review from ran-huang January 22, 2024 02:51
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. label Jan 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-22 02:59:58.63644358 +0000 UTC m=+756840.200741287: ☑️ agreed by ran-huang.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2024
@Oreoxmt Oreoxmt added the lgtm label Jan 22, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jan 22, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2024
@Oreoxmt Oreoxmt closed this Jan 22, 2024
@Oreoxmt Oreoxmt reopened this Jan 22, 2024
@Oreoxmt Oreoxmt merged commit 30eb883 into pingcap:master Jan 22, 2024
23 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2501.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2024
@ti-chi-bot
tiproxy: fix broken links (#2500) (#2501)
4f3701c
@Oreoxmt Oreoxmt deleted the fix/issue-2498 branch July 10, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Link Detected
3 participants
@Oreoxmt @ti-chi-bot @ran-huang