-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: reformat Changefeed config and Server config (#19166) #19331
Merged
ti-chi-bot
merged 10 commits into
pingcap:release-8.5
from
ti-chi-bot:cherry-pick-19166-to-release-8.5
Dec 20, 2024
Merged
cdc: reformat Changefeed config and Server config (#19166) #19331
ti-chi-bot
merged 10 commits into
pingcap:release-8.5
from
ti-chi-bot:cherry-pick-19166-to-release-8.5
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aolin <[email protected]>
Signed-off-by: Aolin <[email protected]>
Signed-off-by: Aolin <[email protected]>
Co-authored-by: xixirangrang <[email protected]>
Co-authored-by: xixirangrang <[email protected]>
Co-authored-by: xixirangrang <[email protected]>
Signed-off-by: Aolin <[email protected]>
Signed-off-by: Aolin <[email protected]>
ti-chi-bot
added
area/ticdc
Indicates that the Issue or PR belongs to the area of TiCDC.
lgtm
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-8.5
This PR is cherry-picked to release-8.5 from a source PR.
type/enhancement
The issue or PR belongs to an enhancement.
labels
Dec 20, 2024
16 tasks
Oreoxmt
approved these changes
Dec 20, 2024
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
area/ticdc
Indicates that the Issue or PR belongs to the area of TiCDC.
lgtm
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-8.5
This PR is cherry-picked to release-8.5 from a source PR.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #19166
What is changed, added or deleted? (Required)
This PR is a first step. It converts the existing format of code blocks to the body heading format for config descriptions in CLI and Configuration Parameters of TiCDC Changefeeds | TiDB Docs and TiCDC Server Configurations | TiDB Docs, like that in TiDB Configuration File | TiDB Docs.
This PR doesn't add new descriptions, except describe some config value as 示例值 for now, because those config items have no description or default value. Some missing explanations need to be added in new PRs.
cdc: reformat Changefeed config and Server config
ref: pingcap/docs#19522 and pingcap/docs#19521
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?