Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: update doc about ddl white list #19151

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

ticdc: update doc about ddl white list #19151

wants to merge 30 commits into from
+60 −38

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Nov 22, 2024 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2024
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
asddongmen
asddongmen reviewed Nov 22, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Nov 25, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated
- rebase auto id
- alter table index visibility
- exchange partition
- reorganize partition
- alter table ttl
- alter table remove ttl

> ***注意：**
Copy link
Member

@lilin90 lilin90 Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种“注意”的方式很少使用，是需要类似 TiDB 功能概览 | TiDB 文档中心的脚注吗？是的话，可以参考 https://github.com/pingcap/docs-cn/blob/master/basic-features.md 里的格式。

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
@wk989898 wk989898 changed the title ticdc: add note about drop index ddl ticdc: update doc about ddl white list Nov 26, 2024
flowbehappy
flowbehappy reviewed Dec 4, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Dec 4, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
flowbehappy
flowbehappy reviewed Dec 4, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated
> ** 注意：**
>
> - 删除最后一个[有效索引](/ticdc/ticdc-overview.md#最佳实践)的 DDL (*号) 不会被同步，并且导致后续数据同步失败。
> - 创建第一个[有效索引](/ticdc/ticdc-overview.md#最佳实践)的 DDL (*号) 会被同步，并且导致后续数据同步失败。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议更详细解释一下。比如“在没有有效索引的表创建第一个有效索引的 DDL 会被同步，并且导致后续数据同步失败。 原因是 xxxx”

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2024
flowbehappy
flowbehappy approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

asddongmen
asddongmen reviewed Dec 5, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

@asddongmen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wk989898 wk989898 requested a review from lilin90 December 10, 2024 08:52
@wk989898
Copy link
Contributor Author

/label v8.4, v8.3, v8.2 required

@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 23, 2024
@qiancai qiancai self-assigned this Dec 24, 2024
@qiancai qiancai self-requested a review December 24, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

@qiancai qiancai Awaiting requested review from qiancai

Assignees

@qiancai qiancai

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wk989898 @flowbehappy @asddongmen @lilin90 @hfxsd @qiancai