Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for ADMIN ALTER DDL JOBS command #19085

Merged
merged 22 commits into from
Dec 2, 2024
Merged

docs: add documentation for ADMIN ALTER DDL JOBS command #19085

merged 22 commits into from
Dec 2, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 15, 2024 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
@hfxsd hfxsd self-assigned this Nov 15, 2024
@hfxsd hfxsd added v8.5 translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 15, 2024
@hfxsd hfxsd self-requested a review November 15, 2024 03:29
fzzf678
fzzf678 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@fzzf678 fzzf678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 15, 2024

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd requested a review from lilin90 November 15, 2024 06:40
hfxsd
hfxsd reviewed Nov 18, 2024
View reviewed changes
sql-statements/sql-statement-admin-alter-ddl.md Outdated
- `ADD INDEX`:
- `THREAD`: 并发度，初始值由系统变量 `tidb_ddl_reorg_worker_cnt` 设置。
- `BATCH_SIZE`: 批大小，初始值由系统变量 [`tidb_ddl_reorg_batch_size`](/system-variables.md#tidb_ddl_reorg_batch_size) 设置。
- `MAX_WRITE_SPEED`: 向每个 TiKV 导入索引记录时的最大带宽限制，初始值由系统变量 [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-从-v850-版本开始引入) 设置。
Copy link
Collaborator

@hfxsd hfxsd Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewer: 变量 tidb_ddl_reorg_max_write_speed 在这个 PR 中：pingcap/docs#19445

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2024
@tangenta tangenta mentioned this pull request Nov 22, 2024
Merged
17 tasks
hfxsd
hfxsd reviewed Nov 25, 2024
View reviewed changes
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-show-ddl.md Outdated Show resolved Hide resolved
@hfxsd hfxsd removed the translation/doing This PR’s assignee is translating this PR. label Nov 25, 2024
Frank945946
Frank945946 reviewed Nov 29, 2024
View reviewed changes
sql-statements/sql-statement-admin-show-ddl.md Outdated
@@ -55,7 +55,7 @@ OWNER_ADDRESS: 0.0.0.0:4000

### `ADMIN SHOW DDL JOBS`

`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近十条结果。该语句的返回结果字段描述如下：
`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近的结果。该语句的返回结果字段描述如下：
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.pingcap.com/zh/tidb/v8.4/sql-statement-admin-show-ddl#admin-show-ddl-jobs
这个文档里还写着是最近的 10 条，是在 v8.5 修改掉了？
@tangenta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

它会取正在运行的十条（如果有）+历史的十条，这里的描述不太准确所以删掉了

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那感觉还是你这个最新的解释更加准确清晰。

sql-statements/sql-statement-admin-show-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Show resolved Hide resolved
Frank945946
Frank945946 approved these changes Dec 2, 2024
View reviewed changes
sql-statements/sql-statement-admin-show-ddl.md Outdated
@@ -55,7 +55,7 @@ OWNER_ADDRESS: 0.0.0.0:4000

### `ADMIN SHOW DDL JOBS`

`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近十条结果。该语句的返回结果字段描述如下：
`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近的结果。该语句的返回结果字段描述如下：
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那感觉还是你这个最新的解释更加准确清晰。

sql-statements/sql-statement-admin-show-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lilin90
lilin90 reviewed Dec 2, 2024
View reviewed changes
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-alter-ddl.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-admin-show-ddl.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 2, 2024
lilin90
lilin90 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 06:28:26.14564428 +0000 UTC m=+1049893.765298796: ☑️ agreed by lilin90.
  • 2024-12-02 06:52:20.258845059 +0000 UTC m=+1051327.878499574: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2024
Merged
17 tasks
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 2, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 76f6555 into pingcap:master Dec 2, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19185.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 2, 2024
@ti-chi-bot
docs: add documentation for ADMIN ALTER DDL JOBS command (#19085) (#1…
c51255c 
…9185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzzf678 fzzf678 fzzf678 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tangenta @hfxsd @ti-chi-bot @lilin90 @Frank945946 @fzzf678