-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove TiDB Binlog after deprecation #18576
Conversation
@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Done in f5d3bd0. |
@Benjamin2037 has confirmed the two new commits that delete more descriptions about Pump and Drainer: ca472d7 and 3b8bf6f. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-verify |
What is changed, added or deleted? (Required)
Starting from TiDB v8.4.0, TiDB Binlog is removed after deprecation. This PR removes and updates documents related to removing TiDB Binlog.
Note:
basic-features.md
and updates the status of all affected features. This PR doesn't update it.aliases
for 21 deleted.md
files in PR *: add aliases for 21 deleted TiDB Binlog docs from dev #18625, to avoid broken 404 links. All the URLs of deleted files will be redirected to those links of v8.3.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?