Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: support pd microservices #15975

Merged
merged 15 commits into from
Mar 25, 2024
Merged

pd: support pd microservices #15975

merged 15 commits into from
Mar 25, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Jan 2, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)

What is the related PR or file link(s)?

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2024
@HuSharp HuSharp requested a review from rleungx February 22, 2024 07:36
@HuSharp HuSharp marked this pull request as ready for review February 22, 2024 07:36
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
tiup/tiup-playground.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
@qiancai qiancai added the v8.0 This PR/issue applies to TiDB v8.0. label Mar 21, 2024
@qiancai qiancai self-assigned this Mar 21, 2024
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Mar 21, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 21, 2024
pd-microservices.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2024
tiup/tiup-playground.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Mar 21, 2024
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Mar 21, 2024
tiup/tiup-playground.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
tiup/tiup-playground.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 22, 2024
pd-microservices.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 08:15:03.114194184 +0000 UTC m=+1623730.136440572: ☑️ agreed by lilin90.
  • 2024-03-25 03:03:12.017127036 +0000 UTC m=+1864219.039373424: ☑️ agreed by qiancai.

@HuSharp HuSharp requested a review from lhy1024 March 25, 2024 03:51
pd-microservices.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

- 只有 TiDB 组件支持通过服务发现直接连接 `tso` 微服务,其他的组件是通过请求转发的方式,将请求通过 PD 转发到 `tso` 微服务以获取时间戳。
- 与[同步部署模式 (DR Auto-Sync)](https://docs.pingcap.com/zh/tidb/stable/two-data-centers-in-one-city-deployment) 特性不兼容。
- 与 TiDB 系统变量 [`tidb_enable_tso_follower_proxy`](/system-variables.md#tidb_enable_tso_follower_proxy-从-v530-版本开始引入) 不兼容。
- 由于集群中可能存在静默 Region,`scheduling` 微服务在进行主备切换时,为避免冗余调度,集群可能存在最多五分钟内没有调度的现象。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要指明系统配置?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd-microservices.md Outdated Show resolved Hide resolved
pd-microservices.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 25, 2024

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pd-microservices.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Mar 25, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3bbb216 into pingcap:master Mar 25, 2024
5 of 7 checks passed
@HuSharp HuSharp deleted the support_pd_ms branch March 25, 2024 06:41
@qiancai qiancai mentioned this pull request Mar 25, 2024
18 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0 This PR/issue applies to TiDB v8.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants