-
Notifications
You must be signed in to change notification settings - Fork 23
change timeouts-in-tidb.md to reflect gc is self-adaptive #74
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -90,6 +90,20 @@ summary: 介绍如何设计数据库中的对象,如索引、字段类型等 | |||
|
|||
- 当使用宽字段类型(如 Text、MediumBlob、MediumText)时,需注意读取并发度,以控制内存使用预防 OOM 。 | |||
|
|||
关于 char 类型的特别说明: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能否考虑把「CHAR:仅仅只有单个字符的字段使用 CHAR(1) 类型,例如性别字段。」这一行放在「关于 char 类型的特别说明:」正上方?
@@ -90,6 +90,20 @@ summary: 介绍如何设计数据库中的对象,如索引、字段类型等 | |||
|
|||
- 当使用宽字段类型(如 Text、MediumBlob、MediumText)时,需注意读取并发度,以控制内存使用预防 OOM 。 | |||
|
|||
关于 char 类型的特别说明: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能否考虑把「CHAR:仅仅只有单个字符的字段使用 CHAR(1) 类型,例如性别字段。」这一行放在「关于 char 类型的特别说明:」正上方?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
每一行上下都需要空一行
关于 char 类型的特别说明: | ||
1. 新框架 ( new_collations_enabled_on_first_bootstrap) | ||
|
||
在 4.0 版本之前,TiDB 只提供了旧的排序规则框架,能够在语法上支持的绝大部分 MySQL 排序规则,但语义上所有的排序规则都当成二进制排序规则。4.0 版本中,TiDB 增加了新的排序规则框架用于在语义上支持不同的排序规则,保证字符串比较时严格遵循对应的排序规则。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缩进 8 个空格,这里多了一个空格。下同
@@ -90,6 +90,20 @@ summary: 介绍如何设计数据库中的对象,如索引、字段类型等 | |||
|
|||
- 当使用宽字段类型(如 Text、MediumBlob、MediumText)时,需注意读取并发度,以控制内存使用预防 OOM 。 | |||
|
|||
关于 char 类型的特别说明: | |||
1. 新框架 ( new_collations_enabled_on_first_bootstrap) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否可以明确下是什么新框架?TiDB 排序规则新框架?
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?