feat: support download uploaded documents #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Rutheniumlmw is attempting to deploy a commit to the pingcap Team on Vercel. A member of the Team first needs to authorize it. |
634750802
requested changes
Dec 23, 2024
634750802
reviewed
Dec 24, 2024
backend/app/api/routes/document.py
Outdated
| headers = {"Content-Length": str(file_size)} | ||
| def iterfile(): | ||
| with filestorage.open(name) as f: | ||
| while chunk := f.read(8192): # 每次读取 8KB |
There was a problem hiding this comment.
Please refer to FastAPI Document. It's not necessary to manually call f.read().
634750802
changed the title
Mini256
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #466