Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json) Explicit drop support for node<18 #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mureinik
Copy link

@mureinik mureinik commented Sep 5, 2024

Followup to #54:
That PR added a statement that support for node<18 is dropped, and amended the CI accordingly.

This PR builds on that and makes this support statement explicit in the package.json.

Followup to pillarjs#54:
That PR added a statement that support for node<18 is dropped, and
amended the CI accordingly.

This PR builds on that and makes this support statement explicit in
the package.json.
@wesleytodd
Copy link
Member

I knew someone would see this and open this PR. I did this intentionally. We are in a process of fixing nearly 10 years of stagnation and are attempting to make the most smooth transition we can for consumers. Since we did not introduce any changes that actually BREAK those versions I have chosen to not change the engines field. This means that we are a bit more free to steward folks forward without putting in arbitrarily roadblocks in the upgrade path.

That said, we do not intend to ship fixes for anything other that security issues to support node versions older than 18. We are working on docs and stuff for this, but it takes time and we are focused on getting the code released and stable first. So, happy to hear your opinion on this, because I anticipated it being controversial.

@mureinik
Copy link
Author

mureinik commented Sep 5, 2024

Egg on my face!

I was not aware this was intentional - #54 didn't mention it, and I thought it was just an oversight.
Apologies for the noise.

@wesleytodd
Copy link
Member

No apologies necessary! I was quite concerned this decision would be seen as the wrong way and I didn't want to cause more confusion by trying to preemptively explain my thinking in case it was never going to become an issue for folks. In open source it is sometimes hard to tell what folks will care about and what they will not even notice, and with the workload we have taken on trying to get these packages unstuck, I was trying to optimize for maintainer time over correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants