Add audio streaming support for generic PCM devices. #209
+95
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlyreen
commented
Mar 19, 2023
charlyreen
commented
- Allow generic PCM devices to stream audio from ALSA via piKVM
- New config parameters in janus.plugin.ustreamer.jcfg:
- pcm_path: Path in /dev/snd/ to PCM device
- pcm_sampling_rate: Sampling rate
- pcm_channels: Number of PCM channels
mdevaev
reviewed
Mar 19, 2023
| @@ -95,7 +95,7 @@ us_audio_s *us_audio_init(const char *name, unsigned pcm_hz) { | |||
|
|
|||
| SET_PARAM("Can't initialize PCM params", snd_pcm_hw_params_any); | |||
| SET_PARAM("Can't set PCM access type", snd_pcm_hw_params_set_access, SND_PCM_ACCESS_RW_INTERLEAVED); | |||
| SET_PARAM("Can't set PCM channels numbre", snd_pcm_hw_params_set_channels, 2); | |||
| SET_PARAM("Can't set PCM channels numbre", snd_pcm_hw_params_set_channels, pcm_channels); | |||
There was a problem hiding this comment.
Could you also fix numbre -> number?
mdevaev
reviewed
Mar 19, 2023
| US_JLOG_INFO("config", "Missing config value: audio.tc358743 OR audio.pcm_path"); | ||
| goto error; | ||
| } | ||
| else { |
mdevaev
reviewed
Mar 19, 2023
| @@ -53,8 +53,21 @@ us_config_s *us_config_init(const char *config_dir_path) { | |||
| } | |||
| if ((config->audio_dev_name = _get_value(jcfg, "audio", "device")) != NULL) { | |||
| if ((config->tc358743_dev_path = _get_value(jcfg, "audio", "tc358743")) == NULL) { | |||
| US_JLOG_INFO("config", "Missing config value: audio.tc358743"); | |||
| goto error; | |||
| if((config->pcm_path = _get_value(jcfg, "audio", "pcm_path")) == NULL) { | |||
There was a problem hiding this comment.
Please use just "pcm" for the config option name: config->pcm_path = _get_value(jcfg, "audio", "pcm")
Also the space required after if.
mdevaev
reviewed
Mar 19, 2023
| @@ -39,6 +39,9 @@ typedef struct { | |||
|
|
|||
| char *audio_dev_name; | |||
| char *tc358743_dev_path; | |||
| char *pcm_path; | |||
| char *pcm_sampling_rate; | |||
mdevaev
reviewed
Mar 19, 2023
| @@ -39,6 +39,9 @@ typedef struct { | |||
|
|
|||
| char *audio_dev_name; | |||
| char *tc358743_dev_path; | |||
| char *pcm_path; | |||
| char *pcm_sampling_rate; | |||
| char *pcm_channels; | |||
|
Has this code been tested? And also, if I remember correctly, OPUS in RTP should always be stereo, shouldn't it? |
|
Sup? Please take a look to my notes, and change type of |
mdevaev
force-pushed
the
master
branch
6 times, most recently
from
b6fc13b
to
ef47fa4
Compare
mdevaev
force-pushed
the
master
branch
2 times, most recently
from
677fbbf
to
e558b0f
Compare
mdevaev
force-pushed
the
master
branch
4 times, most recently
from
6e85e11
to
1803879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.