Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIDI implementation #169

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add MIDI implementation #169

wants to merge 8 commits into from
+887 −124

Conversation

kirikak2
Copy link

@kirikak2 kirikak2 commented May 9, 2023 •
edited
Loading

Summary

This Pull Request adds code to implement MIDI functionality to prk_firmware.

Changes Made

  • Added USB-MIDI device class to prk_firmware
  • Implemented packets for Note On/Off, Control Change, Program Change, and MIDI Realtime messages
  • Implemented Octave Up/Down, Transpose Up/Down, and Velocity Up/Down
  • Implemented MIDI note playback functionality with MML

Concerns

  • Increased the maximum number of symbols from 1000 to 2000 due to the increase in symbol count
  • Some functions cause Syntax Errors when executed with picorbc, so they have been commented out. We would like to resolve this issue so that all comments can be removed.

@kirikak2 kirikak2 changed the title Midi impl Add MIDI implementation May 9, 2023
@kirikak2 kirikak2 mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kirikak2