Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rails 6, various fixes to make it work #76

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

adnikiforov
Copy link
Collaborator

So I thought it will be a good idea to update to Rails 6. Obviously, there is many break changes, but I did not changed anything aside from updating and repairing things. Also didn't touched specs, they should be reworked from scratch (and they are broken anyway)

What I did:

  • Updated to latest Rails 6 release
  • Removed cancan in favor of cancancan (cancan is deprecated)
  • Removed div_for as deprecated since Rails 5
  • Added Rails 6 assets manifest
  • before_filter -> before_action
  • A little bit of code formatting using rubocop
  • Regenerated binstubs

Further recommendations:

  • We desperately need to get rid of ERB and use slim instead. Damn ERB is super ugly.
  • Specs should be redone from scratch.
  • Get rid of css3buttons.

DO NOT MERGE at the moment. We need to release old stable release with Rails 4 first, as a starting point.

@adnikiforov adnikiforov added the Maintaining Maintaining tasks label Sep 22, 2020
@adnikiforov
Copy link
Collaborator Author

Wait for #75

@adnikiforov adnikiforov added the WIP Do not merge, work in progress label Sep 22, 2020
@CamJN CamJN merged commit 2ea2ddd into master Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintaining Maintaining tasks WIP Do not merge, work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants