Update to Rails 6, various fixes to make it work #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I thought it will be a good idea to update to Rails 6. Obviously, there is many break changes, but I did not changed anything aside from updating and repairing things. Also didn't touched specs, they should be reworked from scratch (and they are broken anyway)
What I did:
cancan
in favor ofcancancan
(cancan
is deprecated)div_for
as deprecated since Rails 5before_filter
->before_action
Further recommendations:
css3buttons
.DO NOT MERGE at the moment. We need to release old stable release with Rails 4 first, as a starting point.