Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: decreasing benchmarks average time assertions #566

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Jul 9, 2024

I updated the highest based on the average run on my machine (m1 max)

  ✘ \PhpMyAdmin\SqlParser\Tests\benchmarks\UtfStringBench::benchBuildUtfString # 

    1) mode(variant[time][avg]) > 30 milliseconds ± 10
       = 26195.816536203 > 30000 ± 3000
       = false

  ✘ \PhpMyAdmin\SqlParser\Tests\benchmarks\UtfStringBench::benchGetCharLength # 

    1) mode(variant[time][avg]) > 100 microseconds ± 10
       = 60.75 > 100 ± 10
       = false


@williamdes williamdes merged commit 6dc815b into phpmyadmin:5.10.x Aug 14, 2024
17 checks passed
@williamdes williamdes self-assigned this Aug 14, 2024
@williamdes williamdes added this to the 5.10.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants