Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GPS): allow send attributes in Google PubSub message. #1352

Conversation

p-pichet
Copy link
Contributor

@p-pichet p-pichet commented Jul 2, 2024

No description provided.

@p-pichet
Copy link
Contributor Author

p-pichet commented Jul 2, 2024

@makasim this one should be good.

@Steveb-p
Copy link
Contributor

Steveb-p commented Jul 2, 2024

One of the tests requires an update, since you're changing behavior slightly.

All others are deprecations and warnings (these are awful, but it is how it is).

There was 1 failure:

1) Enqueue\Gps\Tests\GpsProducerTest::testShouldSendMessage
Expectation failed for method name is "publish" when invoked 1 time(s)
Parameter 0 for invocation Google\Cloud\PubSub\Topic::publish(Array (...), Array ()) does not match expected value.
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     'data' => '{"body":"","properties":[],"headers":[]}'
+    'attributes' => Array &1 ()
 )

/home/runner/work/enqueue-dev/enqueue-dev/pkg/gps/GpsProducer.php:42
/home/runner/work/enqueue-dev/enqueue-dev/pkg/gps/Tests/GpsProducerTest.php:55
phpvfscomposer:///home/runner/work/enqueue-dev/enqueue-dev/vendor/phpunit/phpunit/phpunit:60

--

@p-pichet
Copy link
Contributor Author

p-pichet commented Jul 2, 2024

thanks @Steveb-p
The first PR decide to run the CI, i see to close this one

@p-pichet p-pichet closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants