Merge pull request #1371 from JimTools/bugfix/risky-tests

Fixing risky tests

pkg/amqp-bunny/Tests/AmqpConsumerTest.php

@@ -27,11 +27,6 @@ public function testShouldImplementConsumerInterface()
         $this->assertClassImplements(Consumer::class, AmqpConsumer::class);
     }
 
-    public function testCouldBeConstructedWithContextAndQueueAsArguments()
-    {
-        new AmqpConsumer($this->createContextMock(), new AmqpQueue('aName'));
-    }
-
     public function testShouldReturnQueue()
     {
         $queue = new AmqpQueue('aName');

pkg/amqp-bunny/Tests/AmqpProducerTest.php

@@ -24,11 +24,6 @@ class AmqpProducerTest extends TestCase
 {
     use ClassExtensionTrait;
 
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new AmqpProducer($this->createBunnyChannelMock(), $this->createContextMock());
-    }
-
     public function testShouldImplementQueueInteropProducerInterface()
     {
         $this->assertClassImplements(Producer::class, AmqpProducer::class);

pkg/amqp-bunny/Tests/AmqpSubscriptionConsumerTest.php

@@ -17,11 +17,6 @@ public function testShouldImplementQueueInteropSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
-    public function testCouldBeConstructedWithAmqpContextAsFirstArgument()
-    {
-        new AmqpSubscriptionConsumer($this->createAmqpContextMock());
-    }
-
     /**
      * @return AmqpContext|MockObject
      */

pkg/amqp-ext/Tests/AmqpConsumerTest.php

@@ -19,11 +19,6 @@ public function testShouldImplementConsumerInterface()
         $this->assertClassImplements(Consumer::class, AmqpConsumer::class);
     }
 
-    public function testCouldBeConstructedWithContextAndQueueAsArguments()
-    {
-        new AmqpConsumer($this->createContext(), new AmqpQueue('aName'));
-    }
-
     /**
      * @return MockObject|AmqpContext
      */

pkg/amqp-ext/Tests/AmqpContextTest.php

@@ -28,18 +28,6 @@ public function testShouldImplementQueueInteropContextInterface()
         $this->assertClassImplements(Context::class, AmqpContext::class);
     }
 
-    public function testCouldBeConstructedWithExtChannelAsFirstArgument()
-    {
-        new AmqpContext($this->createExtChannelMock());
-    }
-
-    public function testCouldBeConstructedWithExtChannelCallbackFactoryAsFirstArgument()
-    {
-        new AmqpContext(function () {
-            return $this->createExtChannelMock();
-        });
-    }
-
     public function testThrowIfNeitherCallbackNorExtChannelAsFirstArgument()
     {
         $this->expectException(\InvalidArgumentException::class);

pkg/amqp-ext/Tests/AmqpSubscriptionConsumerTest.php

@@ -17,11 +17,6 @@ public function testShouldImplementQueueInteropSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
-    public function testCouldBeConstructedWithAmqpContextAsFirstArgument()
-    {
-        new AmqpSubscriptionConsumer($this->createAmqpContextMock());
-    }
-
     /**
      * @return AmqpContext|MockObject
      */

pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php

@@ -24,11 +24,6 @@ public function testShouldImplementProcessorInterface()
         $this->assertClassImplements(Processor::class, AsyncProcessor::class);
     }
 
-    public function testCouldBeConstructedWithRegistryAndProxyEventDispatcher()
-    {
-        new AsyncProcessor($this->createRegistryMock(), $this->createProxyEventDispatcherMock());
-    }
-
     public function testRejectIfMessageMissingEventNameProperty()
     {
         $processor = new AsyncProcessor($this->createRegistryMock(), $this->createProxyEventDispatcherMock());

pkg/async-event-dispatcher/Tests/PhpSerializerEventTransformerTest.php

@@ -21,11 +21,6 @@ public function testShouldImplementEventTransformerInterface()
         $this->assertClassImplements(EventTransformer::class, PhpSerializerEventTransformer::class);
     }
 
-    public function testCouldBeConstructedWithoutAnyArguments()
-    {
-        new PhpSerializerEventTransformer($this->createContextStub());
-    }
-
     public function testShouldReturnMessageWithPhpSerializedEventAsBodyOnToMessage()
     {
         $transformer = new PhpSerializerEventTransformer($this->createContextStub());

pkg/async-event-dispatcher/Tests/SimpleRegistryTest.php

@@ -18,11 +18,6 @@ public function testShouldImplementRegistryInterface()
         $this->assertClassImplements(Registry::class, SimpleRegistry::class);
     }
 
-    public function testCouldBeConstructedWithEventsMapAndTransformersMapAsArguments()
-    {
-        new SimpleRegistry([], []);
-    }
-
     public function testShouldAllowGetTransportNameByEventName()
     {
         $registry = new SimpleRegistry([

pkg/dbal/Tests/DbalConsumerTest.php

@@ -28,11 +28,6 @@ public function testShouldImplementConsumerInterface()
         $this->assertClassImplements(Consumer::class, DbalConsumer::class);
     }
 
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new DbalConsumer($this->createContextMock(), new DbalDestination('queue'));
-    }
-
     public function testShouldReturnInstanceOfDestination()
     {
         $destination = new DbalDestination('queue');

pkg/dbal/Tests/DbalContextTest.php

@@ -27,11 +27,6 @@ public function testShouldImplementContextInterface()
         $this->assertClassImplements(Context::class, DbalContext::class);
     }
 
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new DbalContext($this->createConnectionMock());
-    }
-
     public function testCouldBeConstructedWithEmptyConfiguration()
     {
         $factory = new DbalContext($this->createConnectionMock(), []);

pkg/dbal/Tests/DbalProducerTest.php

@@ -21,11 +21,6 @@ public function testShouldImplementProducerInterface()
         $this->assertClassImplements(Producer::class, DbalProducer::class);
     }
 
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new DbalProducer($this->createContextMock());
-    }
-
     public function testShouldThrowIfDestinationOfInvalidType()
     {
         $this->expectException(InvalidDestinationException::class);

pkg/dbal/Tests/DbalSubscriptionConsumerTest.php

@@ -25,11 +25,6 @@ public function testShouldImplementSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
-    public function testCouldBeConstructedWithDbalContextAsFirstArgument()
-    {
-        new DbalSubscriptionConsumer($this->createDbalContextMock());
-    }
-
     public function testShouldAddConsumerAndCallbackToSubscribersPropertyOnSubscribe()
     {
         $subscriptionConsumer = new DbalSubscriptionConsumer($this->createDbalContextMock());
@@ -66,6 +61,9 @@ public function testThrowsIfTrySubscribeAnotherConsumerToAlreadySubscribedQueue(
         $subscriptionConsumer->subscribe($barConsumer, $barCallback);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testShouldAllowSubscribeSameConsumerAndCallbackSecondTime()
     {
         $subscriptionConsumer = new DbalSubscriptionConsumer($this->createDbalContextMock());

pkg/dsn/Tests/DsnTest.php

@@ -8,11 +8,6 @@
 
 class DsnTest extends TestCase
 {
-    public function testCouldBeConstructedWithDsnAsFirstArgument()
-    {
-        Dsn::parseFirst('foo://localhost:1234');
-    }
-
     public function testThrowsIfSchemePartIsMissing()
     {
         $this->expectException(\LogicException::class);

pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrineClearIdentityMapExtensionTest.php

@@ -16,11 +16,6 @@
 
 class DoctrineClearIdentityMapExtensionTest extends TestCase
 {
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new DoctrineClearIdentityMapExtension($this->createRegistryMock());
-    }
-
     public function testShouldClearIdentityMap()
     {
         $manager = $this->createManagerMock();

pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php

@@ -17,11 +17,6 @@
 
 class DoctrinePingConnectionExtensionTest extends TestCase
 {
-    public function testCouldBeConstructedWithRequiredAttributes()
-    {
-        new DoctrinePingConnectionExtension($this->createRegistryMock());
-    }
-
     public function testShouldNotReconnectIfConnectionIsOK()
     {
         $connection = $this->createConnectionMock();

pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/ResetServicesExtensionTest.php

@@ -16,10 +16,6 @@
 
 class ResetServicesExtensionTest extends TestCase
 {
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new ResetServicesExtension($this->createResetterMock());
-    }
 
     public function testItShouldResetServices()
     {

pkg/enqueue-bundle/Tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -25,11 +25,6 @@ public function testShouldBeFinal()
         $this->assertClassFinal(Configuration::class);
     }
 
-    public function testCouldBeConstructedWithDebugAsArgument()
-    {
-        new Configuration(true);
-    }
-
     public function testShouldProcessSeveralTransports()
     {
         $configuration = new Configuration(true);

pkg/enqueue-bundle/Tests/Unit/DependencyInjection/EnqueueExtensionTest.php

@@ -30,11 +30,6 @@ public function testShouldBeFinal()
         $this->assertClassFinal(EnqueueExtension::class);
     }
 
-    public function testCouldBeConstructedWithoutAnyArguments()
-    {
-        new EnqueueExtension();
-    }
-
     public function testShouldRegisterConnectionFactory()
     {
         $container = $this->getContainerBuilder(true);

pkg/enqueue-bundle/Tests/Unit/EnqueueBundleTest.php

@@ -15,9 +15,4 @@ public function testShouldExtendBundleClass()
     {
         $this->assertClassExtends(Bundle::class, EnqueueBundle::class);
     }
-
-    public function testCouldBeConstructedWithoutAnyArguments()
-    {
-        new EnqueueBundle();
-    }
 }

pkg/enqueue-bundle/Tests/Unit/Profiler/MessageQueueCollectorTest.php

@@ -23,11 +23,6 @@ public function testShouldExtendDataCollectorClass()
         $this->assertClassExtends(DataCollector::class, MessageQueueCollector::class);
     }
 
-    public function testCouldBeConstructedWithEmptyConstructor()
-    {
-        new MessageQueueCollector();
-    }
-
     public function testShouldReturnExpectedName()
     {
         $collector = new MessageQueueCollector();

pkg/enqueue/Tests/ArrayProcessorRegistryTest.php

@@ -18,11 +18,6 @@ public function testShouldImplementProcessorRegistryInterface()
         $this->assertClassImplements(ProcessorRegistryInterface::class, ArrayProcessorRegistry::class);
     }
 
-    public function testCouldBeConstructedWithoutAnyArgument()
-    {
-        new ArrayProcessorRegistry();
-    }
-
     public function testShouldThrowExceptionIfProcessorIsNotSet()
     {
         $registry = new ArrayProcessorRegistry();

pkg/enqueue/Tests/Client/ChainExtensionTest.php

@@ -29,11 +29,6 @@ public function testShouldBeFinal()
         $this->assertClassFinal(ChainExtension::class);
     }
 
-    public function testCouldBeConstructedWithExtensionsArray()
-    {
-        new ChainExtension([$this->createExtension(), $this->createExtension()]);
-    }
-
     public function testThrowIfArrayContainsNotExtension()
     {
         $this->expectException(\LogicException::class);

pkg/enqueue/Tests/Client/ConsumptionExtension/DelayRedeliveredMessageExtensionTest.php

@@ -23,10 +23,6 @@
 
 class DelayRedeliveredMessageExtensionTest extends TestCase
 {
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new DelayRedeliveredMessageExtension($this->createDriverMock(), 12345);
-    }
 
     public function testShouldSendDelayedMessageAndRejectOriginalMessage()
     {

pkg/enqueue/Tests/Client/ConsumptionExtension/ExclusiveCommandExtensionTest.php

@@ -34,11 +34,6 @@ public function testShouldBeFinal()
         $this->assertClassFinal(ExclusiveCommandExtension::class);
     }
 
-    public function testCouldBeConstructedWithDriverAsFirstArgument()
-    {
-        new ExclusiveCommandExtension($this->createDriverStub());
-    }
-
     public function testShouldDoNothingIfMessageHasTopicPropertySetOnPreReceive()
     {
         $message = new NullMessage();

pkg/enqueue/Tests/Client/ConsumptionExtension/FlushSpoolProducerExtensionTest.php

@@ -30,11 +30,6 @@ public function testShouldImplementEndExtensionInterface()
         $this->assertClassImplements(EndExtensionInterface::class, FlushSpoolProducerExtension::class);
     }
 
-    public function testCouldBeConstructedWithSpoolProducerAsFirstArgument()
-    {
-        new FlushSpoolProducerExtension($this->createSpoolProducerMock());
-    }
-
     public function testShouldFlushSpoolProducerOnEnd()
     {
         $producer = $this->createSpoolProducerMock();

pkg/enqueue/Tests/Client/ConsumptionExtension/LogExtensionTest.php

@@ -55,11 +55,6 @@ public function testShouldSubClassOfLogExtension()
         $this->assertClassExtends(\Enqueue\Consumption\Extension\LogExtension::class, LogExtension::class);
     }
 
-    public function testCouldBeConstructedWithoutAnyArguments()
-    {
-        new LogExtension();
-    }
-
     public function testShouldLogStartOnStart()
     {
         $logger = $this->createLogger();

pkg/enqueue/Tests/Client/ConsumptionExtension/SetRouterPropertiesExtensionTest.php

@@ -27,11 +27,6 @@ public function testShouldImplementMessageReceivedExtensionInterface()
         $this->assertClassImplements(MessageReceivedExtensionInterface::class, SetRouterPropertiesExtension::class);
     }
 
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new SetRouterPropertiesExtension($this->createDriverMock());
-    }
-
     public function testShouldSetRouterProcessorPropertyIfNotSetAndOnRouterQueue()
     {
         $config = Config::create('test', '.', '', '', 'router-queue', '', 'router-processor-name');

pkg/enqueue/Tests/Client/ConsumptionExtension/SetupBrokerExtensionTest.php

@@ -21,11 +21,6 @@ public function testShouldImplementStartExtensionInterface()
         $this->assertClassImplements(StartExtensionInterface::class, SetupBrokerExtension::class);
     }
 
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new SetupBrokerExtension($this->createDriverMock());
-    }
-
     public function testShouldSetupBroker()
     {
         $logger = new NullLogger();

pkg/enqueue/Tests/Client/DelegateProcessorTest.php

@@ -13,11 +13,6 @@
 
 class DelegateProcessorTest extends TestCase
 {
-    public function testCouldBeConstructedWithRequiredArguments()
-    {
-        new DelegateProcessor($this->createProcessorRegistryMock());
-    }
-
     public function testShouldThrowExceptionIfProcessorNameIsNotSet()
     {
         $this->expectException(\LogicException::class);

pkg/enqueue/Tests/Client/DriverFactoryTest.php

@@ -61,11 +61,6 @@ public function testShouldBeFinal()
         $this->assertTrue($rc->isFinal());
     }
 
-    public function testCouldBeConstructedWithoutAnyArguments()
-    {
-        new DriverFactory();
-    }
-
     public function testThrowIfPackageThatSupportSchemeNotInstalled()
     {
         $scheme = 'scheme5b7aa7d7cd213';