Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Force APNS | Added boolean ios init Option apnsForce to force apns | Updated docs as well #2736

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisTomAlx
Copy link

@ChrisTomAlx ChrisTomAlx commented Apr 3, 2019

Description

Default : False [Uses FCM if GoogleServiceInfo.plist is present and APNS if not]
If set to true (Boolean) or "true" (String) within ios options in init, it will force APNS to be used even if GoogleServiceInfo.plist is present in the project

Related Issue

#1770
#2138

Motivation and Context

Allow forcing of APNS and FCM as necesssary from JS instead of having to edit the GoogleServiceInfo.plist file everytime

How Has This Been Tested?

Added GoogleServiceInfo.plist in ios and made sure apnsForce : true and apnsForce : "true" was causing APNS to be used over FCM. Also tested by removing apnsForce and setting apnsForce : false while GoogleServiceInfo.plist was present and it defaulted to FCM.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Default : False [Uses FCM if GoogleServiceInfo.plist is present and APNS if not]
If set to true (Boolean) or "true" (String) within ios options in init, it will force APNS to be used even if GoogleServiceInfo.plist is present in the project
@ChrisTomAlx ChrisTomAlx changed the title Added boolean ios init Option apnsForce to force apns | Updated docs as well Force APNS | Added boolean ios init Option apnsForce to force apns | Updated docs as well Apr 3, 2019
@ChrisTomAlx
Copy link
Author

Please let me know if I missed something, I will raise a new pull request.
Also thank you for this wonderful plugin.

Cheers,
Chris
Neutrinos

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant