Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/feature/batman tours #125

Open
wants to merge 1 commit into
base: release/v17.09-pheno-cerebellin
Choose a base branch
from

Conversation

jianlianggao
Copy link
Member

Hi Pablo,

I created this branch from the cerebellin release branch.
I don't know why from my GitHub desktop, it shows all feature branches with preceding origin/. So I added origin as preceding. If you need to remove it, please do it for me. Thank you very much,

added BATMAN interactive Galaxy tour help
@pcm32
Copy link
Member

pcm32 commented Jan 30, 2018

I presume you only want to add the last commit, right? Did you make a git pull from the release branch before branching for the new feature? You are also trying to merge to develop, not the release branch... let me fix that.

@pcm32 pcm32 changed the base branch from develop to release/v17.09-pheno-cerebellin January 30, 2018 15:27
@pcm32
Copy link
Member

pcm32 commented Jan 30, 2018

There!

Copy link
Member

@pcm32 pcm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you confirm that this works on minikube?

@pcm32
Copy link
Member

pcm32 commented Jan 30, 2018

Can you please also set the release tag for batman? Thanks

@pcm32
Copy link
Member

pcm32 commented Feb 26, 2018

I have run these Tour, maybe it could be improved by adding some automated data download, so that the user actually runs something meaningful. Maybe @vagelishand can help on this? @vagelishand you can probably ask for people at IPB and Oxford for advise, as they have done other tours!

@sneumann
Copy link
Member

HI @vagelishand, which data should be used for this tour ?
Yours, Steffen

@djcomlab
Copy link
Member

Any more info on this @vagelishand?

@michaelvanvliet michaelvanvliet self-assigned this Jul 2, 2018
@djcomlab
Copy link
Member

djcomlab commented Jul 3, 2018

There's been no activity on this PR for a long while and it was intended for release/v17.09-pheno-cerebellin, so I think we should consider closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants