Fixed tags block not being hidden on submission error causing it to hide on cancel #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you begin
Right now, if you would try to submit a tag change with blacklisted tag, wait for error to show up and then cancel the editing, block with tag view will disappear from the page:
Screencast.from.2024-12-15.00-30-51.webm
It was caused by the template not marking tags block as being hidden, and JS toggling the hide class. This PR would correctly mark the block as hidden, fixing the problem:
Screencast.from.2024-12-15.00-32-21.webm