Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resetting of the auto-completed query not working correctly #368

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

koloml
Copy link
Contributor

@koloml koloml commented Nov 14, 2024

Before you begin

  • I understand my contributions may be rejected for any reason
  • I understand my contributions are for the benefit of Derpibooru and/or the Philomena software
  • I understand my contributions are licensed under the GNU AGPLv3
  • I understand all of the above

Noticed that search fields started resetting the original query incorrectly. Instead of restoring the whole query, field gets only the selected term:

Screencast.from.2024-11-14.22-35-08.webm

First commit fixes that:

Screencast.from.2024-11-14.22-37-26.webm

Second commit just forces the selection to move to the end of the selected term instead of the end of the whole query:

Screencast.from.2024-11-14.22-44-01.webm

@liamwhite liamwhite merged commit 1bd5e89 into philomena-dev:master Nov 14, 2024
4 checks passed
@koloml koloml deleted the fix-search-field-reset branch November 14, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants