check if input is a string before checking its length

philiplb · Mar 4, 2021 · b0f3189 · b0f3189
1 parent e52d851
commit b0f3189
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/Valdi/Validator/LengthBetween.php b/src/Valdi/Validator/LengthBetween.php
@@ -32,7 +32,8 @@ class LengthBetween extends AbstractComparator
      */
     protected function isValidComparison($value, $parameters)
     {
-        return $this->isAllNumeric($parameters[0], $parameters[1])
+        return is_string($value)
+            && $this->isAllNumeric($parameters[0], $parameters[1])
             && strlen($value) >= $parameters[0]
             && strlen($value) <= $parameters[1];
     }

diff --git a/src/Valdi/Validator/MaxLength.php b/src/Valdi/Validator/MaxLength.php
@@ -27,6 +27,8 @@ class MaxLength extends AbstractComparator
      */
     protected function isValidComparison($value, $parameters)
     {
-        return is_numeric($parameters[0]) && strlen($value) <= $parameters[0];
+        return is_string($value) 
+            && is_numeric($parameters[0]) 
+            && strlen($value) <= $parameters[0];
     }
 }
diff --git a/src/Valdi/Validator/MinLength.php b/src/Valdi/Validator/MinLength.php
@@ -27,7 +27,8 @@ class MinLength extends AbstractComparator
      */
     protected function isValidComparison($value, $parameters)
     {
-        $length = strlen($value);
-        return is_numeric($parameters[0]) && $length >= $parameters[0];
+        return is_string($value) 
+            && is_numeric($parameters[0]) 
+            && strlen($value) >= $parameters[0];
     }
 }