Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated text theme getters #97

Open
philitell opened this issue May 15, 2024 · 7 comments
Open

Remove deprecated text theme getters #97

philitell opened this issue May 15, 2024 · 7 comments

Comments

@philitell
Copy link

philitell commented May 15, 2024

Error when running on flutter 3.22:

drag_and_drop_lists-0.3.3/lib/programmatic_expansion_tile.dart:236:33: Error: The getter 'subtitle1' isn't defined for the class 'TextTheme'.

I think this section needs to be updated:

  @override
  void didChangeDependencies() {
    final ThemeData theme = Theme.of(context);
    _borderColorTween.end = theme.dividerColor;
    _headerColorTween
      ..begin = theme.textTheme.subtitle1!.color   // ****** use correct getter ******* e.g. bodySmall or titleSmall
      ..end = theme.colorScheme.secondary;
@philitell
Copy link
Author

Thanks for this great package - i'm using it in two projects and it works great

@dmitry-comet
Copy link
Contributor

#98

@decisionslab2
Copy link

same issue in Flutter 3.22

@philitell
Copy link
Author

Please release #98

@florinleu
Copy link

florinleu commented Jun 2, 2024

I think no one is maintaining this package anymore. And unfortunately this issue is blocking us from upgrading to flutter 3.22 and above.

@paulHempel
Copy link

Workaround with #98 fork (thanks @dmitry-comet):

  drag_and_drop_lists:
    git:
      url: https://github.com/dmitry-comet/DragAndDropLists.git
      ref: 04715d15ec1a679cf0bc4fcfada75155c9443388

Replace the current version in your pubspec.yaml with the git commit.

@philip-brink
Copy link
Owner

Apologies for the long delay, I haven't been using flutter at all for quite a while. I've merged in #98 (thanks @dmitry-comet !) and published as v 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants