-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Deck App #944
Comments
@pabloeisenhut Do you plan on implementing it yourself? |
No, I thought I would suggest that. Or is that what the Matrix channel is for? |
This is the right place :) If you wanted to implement it yourself I would have assigned you, so that's why I asked |
Very nice :). Do you mind if I suggest a few more apps? |
Sure, but let's quickly discuss those on Matrix to check if they make sense for us |
We can only realistically implement the Deck app if we have generated OpenAPI specs for it but luckily the maintainer of the app is interested in adding support for it, so it should be possible eventually. |
@paulHempel let's continue the discussion here :) |
Some things I already did test in my personal project:
|
For general adaptive design we already have #307, but there hasn't been any work on it for a long time. |
The figma design looks pretty cool and should definitely be doable with flutter! Let me know if you have any questions or need any other help. |
For initial testing purposes you could write an OpenAPI specification by hand based on https://github.com/nextcloud/deck/blob/main/docs/API.md, as I already said we can only accept specs generated by https://github.com/nextcloud/openapi-extractor as everything else is simply not maintainable and more error-prone. |
@paulHempel would you be comfortable with adapting deck to support the generated OpenAPI specs? It's basically following https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-openapi.html and whatever the tool tells you to fix. I had a quick look at the code and I have some hope that it should be easy to make the necessary changes (but it could also turn out to be very complex). If not I could give it a try as I already have a lot of experience in adapting existing codebases, but it would not be a high priority for me at the moment as I'm focusing on other things at the moment. |
I had the same thought, and found the link as well. My PHP skills are basically non-existent, but that shouldn't be to much of a problem for writing some annotations. If you can do some reviewing, I can do the grunt work. It wouldn't need to be merge-able to begin with, I guess, when we can locally extract the OpenAPI specs and do it properly for a PR when there is time. I'll take an in-depth look at the documentation the coming days and try to set things up locally. |
Sounds good, I can definitely review it! Using in-progress stuff is fine for me, as long as we have it ready before merging it into main. |
No description provided.
The text was updated successfully, but these errors were encountered: