Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typechecking to build process #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexrecuenco
Copy link
Contributor

I set typescript version to 5.6 until this is fixed, which will likely be soon

@alexrecuenco
Copy link
Contributor Author

alexrecuenco commented Nov 26, 2024

I wouldn't be confident merging this until the linting issues are fixed, and we see the job get all the way to the build step.

I run it locally however and there are some type issues to address

Found 565 errors in 19 files.

Errors  Files
    13  ../node_modules/lodash.isregexp/index.js:11
    13  ../node_modules/postcss-sanitize/index.js:6
     1  ../src/extension.js:7
     1  main.js:1
   489  node_modules/vue-virtual-scroller/dist/vue-virtual-scroller.umd.js:3
    14  src/components/PromiseForm.vue:19
     1  src/directives/drop.js:36
     4  src/directives/moveable.js:21
     3  src/state/commit-stats.js:75
     1  src/state/store.js:129
     5  src/utils/log-parser.js:219
     1  src/views/AllBranches.vue:10
     1  src/views/CommitDetails.vue:151
     4  src/views/CommitRow.vue:21
     1  src/views/CommitsDetails.vue:60
     3  src/views/GitInput.vue:27
     1  src/views/History.vue:16
     4  src/views/MainView.vue:42
     5  src/vue-app.js:4

Although I think the Vue Extension really dislikes the jsconfig.json, and it would prefer that file be called tsconfig.json (you can still set it to allowJS: true and checkJS: true)

@phil294
Copy link
Owner

phil294 commented Dec 7, 2024

Looks good. I'll fix the Linter messages first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants