Bugfix/91-cssparserhelper-unescape-url

[shagkur]

This is the PR for issue #91

[phax]

Haha - also just started an implementation :)

[shagkur]

@phax Tell me if i should Decline this PR?

[phax]

@shagkur I like my version better because it is a bit "more clear", but I need to crosscheck the consistency to see if it is identical :)

[phax]

Anyway our effort is highly appreciated!!!

[shagkur]

@phax Yes, maybe there're certain situations where not all escpae sequences are covered in you implementation. The one i've taken (i.e. not written by me) seems to be quite mature on that regard.

[phax]

@shagkur Yes indeed, your implementation covers more chars.
But e.g. the special character selection does not seem to match the CSS3 syntax:

The release syntax of CSS v3 only uses the hex digits: https://www.w3.org/TR/css-syntax-3/#consume-an-escaped-code-point

Also CSS 2.1 syntax only allows hex-chars but not " !"#$%&\()*+...: https://www.w3.org/TR/CSS2/syndata.html#tokenization

So I would prefer to stick with the "standards based solution". What do you think?

[shagkur]

Indeed all these speical chars handling, as in my implementation, can be omitted and just passed on. I think, from looking at it in more detail, the only special one which needs to be even dropped is the escaped '\n', i.e. "\\n". I believe that's the only one you need to consider in your implementation. Other than that i'm quite fine with your solution and am happy to decline this PR in favour of your fix.

[shagkur]

Btw. will the new released version be available on mavenrepository then?

[shagkur]

Closed in favour of @phax standard based fix

[phax]

Okay, noted. Yes of course the new version will be available on Maven Central as 7.0.1 soon

[phax]

Sorry, no release. See #93 and #91 for the explanation