-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make R Consortium more prominent on home page of website #123
Open
jcabercrombie
wants to merge
4
commits into
master
Choose a base branch
from
122_emphasize_r_consortium
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello Jaxon,
Thank you for your quick response to my concerns. I have passed your
proposed solutions to Henrik Bengtsson, chair of the ISC, and Jesse Casman
who heads up our marketing efforts.
I believe that the R Consortium Logo should be displayed prominently next
to the R Validation Hub Logo on the landing page and that the text ... "R
Validation Hub, an R Consortium Working group" should also be prominently
displayed on the landing page.
However, I will defer to whatever Henrik and Jesse think is reasonable.
Thank you,
Joe
…On Tue, Aug 13, 2024 at 4:11 PM Jaxon Abercrombie ***@***.***> wrote:
Hi @joseph-rickert <https://github.com/joseph-rickert>,
To make the R Consortium pieces on our home page more prominent, I
added/changed the following:
1. Made the R Consortium a part of the image used in the very first
carousel item on our home page.
2. Added text for and a link to the R Consortium in the text of the
first carousel item on our home page.
3. Redid the logo in the "Partner Initiatives" section we have toward
the bottom of the home page so that it fits with others. It seems to only
work with more square logos.
4. I made the R Consortium appear first in the list of partner
initiatives to prioritize it there as well.
After checking out the deployed sample site in this PR, you let me know if
this is more along the lines of what you were hoping to have? @anujadas185
<https://github.com/anujadas185> relayed to me a quick message this
morning about your request to make things more prominent and these were the
changes I thought could work best.
*Note: changing the actual top left logo on the site is not possible with
our current theme because it is restricted to a really small amount of
pixels, and unfortunately any text and a smaller R Consortium logo become
too blurred/pixelated to be readable. I tried a bunch of different versions
and nothing was working out.*
Thank you,
Jaxon
------------------------------
You can view, comment on, or merge this pull request online at:
#123
Commit Summary
- e06d924
<e06d924>
update carousel and carousel image to make r consortium more prominent
- cf22320
<cf22320>
rename partner initiative yaml files to reorder them
- f95d62a
<f95d62a>
bring in squared r consortium logo to work with partner initiatives section
- b466c4e
<b466c4e>
fix title
File Changes
(6 files <https://github.com/pharmaR/pharmaR.github.io/pull/123/files>)
- *M* data/carousel/mission.yaml
<https://github.com/pharmaR/pharmaR.github.io/pull/123/files#diff-333c3af35e204f8db735ca4e25549d4be10a5a5b6db21689eef0de266e52e140>
(5)
- *R* data/clients/1_rconsort.yaml
<https://github.com/pharmaR/pharmaR.github.io/pull/123/files#diff-17436cf6588d68bd2eb6248ceade87a83b584df5f3156fa7c373dc0a22e852c0>
(0)
- *R* data/clients/2_phuse.yaml
<https://github.com/pharmaR/pharmaR.github.io/pull/123/files#diff-8c9e0ceb4b23ed6c24f5da18549b8ffe1d4d1135bafd6db790c46bbf7bd4c53e>
(0)
- *R* data/clients/3_psi.yaml
<https://github.com/pharmaR/pharmaR.github.io/pull/123/files#diff-a4c7d54358eb08a38769a629f04df23b767261b9c646cca52e5469732ec4f7e0>
(0)
- *M* static/img/carousel/r_val_logo.png
<https://github.com/pharmaR/pharmaR.github.io/pull/123/files#diff-33f70f31deea2f32cb6b6c4468b46d9f1360831a991fb1fe7fe21b6ca24ce8a1>
(0)
- *M* static/img/clients/rconsort.png
<https://github.com/pharmaR/pharmaR.github.io/pull/123/files#diff-f5d548fd7d19cf04e072607657c54f8a40c7b364ae855c4574173905cb49510e>
(0)
Patch Links:
- https://github.com/pharmaR/pharmaR.github.io/pull/123.patch
- https://github.com/pharmaR/pharmaR.github.io/pull/123.diff
—
Reply to this email directly, view it on GitHub
<#123>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN22VRFVKSDCBEHAFQY543ZRKHDNAVCNFSM6AAAAABMPGQZOKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DINBUGY4TOMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Joseph B. Rickert
Executive Director, R Consortium
408.489.0566
|
@joseph-rickert - sounds great! Thank you for reaching out to other folks so we can display things best. Looking forward to what others say and what we end up doing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @joseph-rickert,
To make the R Consortium pieces on our home page more prominent, I added/changed the following:
After checking out the deployed sample site in this PR, you let me know if this is more along the lines of what you were hoping to have? @anujadas185 relayed to me a quick message this morning about your request to make things more prominent and these were the changes I thought could work best.
Note: changing the actual top left logo on the site is not possible with our current theme because it is restricted to a really small amount of pixels, and unfortunately any text and a smaller R Consortium logo become too blurred/pixelated to be readable. I tried a bunch of different versions and nothing was working out.
Thank you,
Jaxon