-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MAC address support #101
Conversation
@t-kataym, could you please plan review of this ready PR by pgspider team? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkgrgis Thank you very much for your hard work.
I have some comment for this PR. Please help me to check them.
All your comments have been checked, @son-phamngoc ! Please ensure now this PR is normal. I'll squash all commits if all is good before merging. |
@son-phamngoc, look like all of the problems are resolved. Please confirm current implementation and start 3rd round of review. |
@mkgrgis Please check 2 comments #101 (comment) and #101 (comment). I think this PR will be OK for my review after you fixed them. |
Thanks, @son-phamngoc ! All problems are fixed. This PR is ready for squashing and review by @t-kataym . |
@son-phamngoc , FYI rebased and merged branch |
@son-phamngoc , could you please explain current status of this PR? Is it planned for merging after PostGIS PR? |
@mkgrgis We are in progress to release new version for supporting PostgreSQL 17. Could you wait for that and then rebase this PR? Then I would like to merge it. |
No problems, @t-kataym ! Like most for other my PRs here are no many changes expected. |
@t-kataym , why not inverse order? How do you think, is PostgreSQL 17 support patch for this PR simpler than rebase patch for this PR after PostgreSQL 17 support? |
@mkgrgis I'm sorry for the inconvenience. It comes from an internal process for release in our company. I appreciate your understanding. |
Thanks for clarification, @t-kataym ! I have understood there is private draft branches which have priority for merging during release process. |
@t-kataym, rebasing is complete. Please review current result or/and discuss previous results of the PR with @son-phamngoc. |
@mkgrgis Thank you for your effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkgrgis Thanks for your hard work.
I have some comments. Please help me to check them.
@son-phamngoc , look like all problems are resolved. I am ready to merge this PR to GIS branch if this PR will be merged to pgspider's master. |
Thanks for review, @son-phamngoc ! |
@mkgrgis Thank you for your effort. |
This PR implements PostgreSQL
macaddr
andmacaddr8
columns support as possible mixed affinity column in SQLite. The nearest affinity selected asinteger
because of there are many fast operations in SQLite including|
and&
.After this PR
sqlite_fdw
will can deal with both12-34-56-78-9A-BC
text
,0x0123456789ABC
integer
andX'0123456789ABC'
blob
notations.In this PR also:
types
instead ofextra
because of tests of different data types are majority of tests inextra
subdirectory.sed
fromtest.sh
changed to environment variableREGRESS
to deal with partial or non-default tests. This allows defineREGRESS
and do not touchMakefile
content. In case of voidREGRESS
variable default list of tests is applied.