Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of builtin main menu buttons #174

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jmgao
Copy link
Contributor

@jmgao jmgao commented Nov 17, 2024

I got annoyed by the useless notebooks button, so I added a way to remove or configure the label/icons on the builtin menu items.

This config:

menu_item :library    :KOReader           :cmd_spawn          :quiet:exec /mnt/onboard/.adds/koreader/koreader.sh
experimental:menu_main_15505_enabled:0
experimental:menu_main_15505_0_enabled:0
experimental:menu_main_15505_1_label:Books
experimental:menu_main_15505_2_enabled:1
experimental:menu_main_15505_3_enabled:0
experimental:menu_main_15505_default:1

results in this:
screencap

(The Home button is removed, but you'll still spawn in there on initial boot: it'd be nice to be able to specify a default, but I'm not entirely sure what the best way of doing so is. Injecting click events in qt seems a lot less trivial than I would expect...)

@jmgao jmgao requested a review from pgaskin as a code owner November 17, 2024 06:35
Copy link
Owner

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pgaskin pgaskin merged commit 2d06985 into pgaskin:master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants