Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor quoting in FetchStmt #267

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

rjuju
Copy link
Contributor

@rjuju rjuju commented Oct 20, 2024

Regression tests updated to test all cursor related statement with a name that requires quoting.

@rjuju
Copy link
Contributor Author

rjuju commented Oct 20, 2024

Note that the problem exist in all version, so it should be applied to all the branches.

rjuju and others added 2 commits October 31, 2024 16:46
Regression tests updated to test all cursor related statement with a name that
requires quoting.
@msepga msepga changed the base branch from 16-latest to 17-latest October 31, 2024 20:50
@msepga
Copy link
Contributor

msepga commented Oct 31, 2024

Thanks for the change, @rjuju! I've rebased this and moved the test case to deparse_tests.c, as the test/sql/ folder is extracted directly from the Postgres source tree.

@msepga msepga merged commit e1a98c3 into pganalyze:17-latest Oct 31, 2024
14 checks passed
msepga added a commit that referenced this pull request Oct 31, 2024
* Fix cursor quoting in FetchStmt

Regression tests updated to test all cursor related statement with a name that
requires quoting.

* Test quoting in `deparse_tests.c`

---------

Co-authored-by: msepga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants