Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately send query run results #649

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Immediately send query run results #649

merged 1 commit into from
Dec 3, 2024

Conversation

seanlinsley
Copy link
Member

Query runs are submitted as part of activity snapshots every 10 seconds, but that creates an unnecessary latency. This PR improves that by adding a new snapshot type which is submitted immediately once a query run is complete.

Note that we'll want to continue submitting query runs as part of activity snapshots so that:

  • long-running queries are reported as running before they're complete
  • the result is still received if network issues caused the query run snapshot to be lost (activity snapshots repeatedly submit query runs for 10 minutes after they're complete, to be sure we receive the result)

@seanlinsley seanlinsley requested a review from a team December 3, 2024 15:23
@seanlinsley seanlinsley merged commit cb1c854 into main Dec 3, 2024
9 checks passed
@seanlinsley seanlinsley deleted the query-run-snapshot branch December 3, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants