Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up main.go #609

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Split up main.go #609

merged 1 commit into from
Oct 8, 2024

Conversation

seanlinsley
Copy link
Member

At 737 lines long, I've found it difficult to navigate main.go. This PR breaks out the run function and its dependent functions into a separate runner/run.go file to try and improve that.

@seanlinsley seanlinsley requested a review from a team October 8, 2024 19:38
msakrejda
msakrejda approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@msakrejda msakrejda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good call.

@seanlinsley seanlinsley merged commit 1792918 into main Oct 8, 2024
9 checks passed
@seanlinsley seanlinsley deleted the split-main branch October 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msakrejda msakrejda msakrejda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlinsley @msakrejda