Fix DISABLE_CITUS_SCHEMA_STATS config reading #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in #562 missed that the updated config-reading code was only for config read from environment variables. Config from the config file was not pre-processed, so any currently-documented values of disable_citus_schema_stats specified there would be ignored, and relation and index stats would always be collected. Config specified via individual environment variables worked as expected. Since the new buggy behavior of the setting is not yet in a released version, and not yet documented, it does not need a CHANGELOG entry.
lfittl
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #562 missed that the updated config-reading code was
only for config read from environment variables. Config from the
config file was not pre-processed, so any currently-documented values
of disable_citus_schema_stats specified there would be ignored, and
relation and index stats would always be collected. Config specified
via individual environment variables worked as expected.
Since the new buggy behavior of the setting is not yet in a released
version, and not yet documented, it does not need a CHANGELOG entry.