Docker image: Don't reload when calling "test" command #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we changed --test to automatically reload, we forgot to explicitly avoid that in the case of the Docker image. In the Docker situation we would typically find two separate containers during a test, the one used for the test, and the regular container running in the background. Thus, the test won't be able to reload the PID that's running in a separate container / cgroups namespace.
msakrejda
approved these changes
Jan 9, 2024
For Heroku that'd be more a documentation thing, right? (since we don't have any special reload task in the Procfile currently) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we changed --test to automatically reload, we forgot to explicitly avoid that in the case of the Docker image. In the Docker situation we would typically find two separate containers during a test, the one used for the test, and the regular container running in the background. Thus, the test won't be able to reload the PID that's running in a separate container / cgroups namespace.