Several Improvements #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with `time` type * Fix issue with negative numerics * Remove support for `send_at_once`, it is now synchronous by default * Use `copy_data` block from pg * Use `sync_put_copy_data` from pg and flush at the end * Add support for `geometry` and `geogrphy` * Add integrations tests using a Dummy rails App (See [spec/dummy](spec/dummy)) * Remove the unused `use_tempfile` options from `EncodeForCopy` * Add explicit dependency to the [pg](https://rubygems.org/gems/pg/versions/1.3.4) gem, with a version minimum to 1.3.0 as we are using the `sync_put_copy_data` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timetypesend_at_once, it is now synchronous by defaultcopy_datablock from pgsync_put_copy_datafrom pg and flush at the endgeometryandgeogrphyuse_tempfileoptions fromEncodeForCopysync_put_copy_datamethodIt is a lot of changes, and I appreciate it is too much. Also very sorry that everything comes at one huge commit