Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catalan translation #387

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

J0anJosep
Copy link
Contributor

I have translated the game into Catalan.
There is no emoji for the Catalan flag. I have chosen the "?" flag, although it could be changed with the "Andorra" flag.

Please let me know if I have to modify anything.

@SKPG-Tech
Copy link
Member

Sorry, there seems to be a mistake with the mistake checker! Your translation is all good.
Sorry for the inconvenience. I will fix this soon the next following day, you don't need to do anything further!

Thank you for translating.

@pewpewlive pewpewlive deleted a comment from github-actions bot Jul 1, 2024
@SKPG-Tech
Copy link
Member

Everything seems to be in order! I deleted the incorrect comment and fixed the issues. Your translation is mistake-free and is ready to land. I also changed the flag to the one you mentioned. Thanks for doing this!

@SKPG-Tech
Copy link
Member

@J0anJosep a few questions regarding some symbols though. The game doesn't have some of the used symbols in the translation strings and I'd like to ask you about them and what they mean so they can be added to the game.

In this file, what is the · symbol used for and how should it be represented in-game?

As for , « and ò, similar characters already exist and can be added no problem!

@SKPG-Tech
Copy link
Member

Another question. The translations for "off" ("desactivat/da") and "on" ("activat/da") are too long when viewed in-game and cause issues. Can it be written a bit shorter?

image
image

Best case solution should fit inside this small button, if it can't that's fine, but it would be great to be close
image

@J0anJosep
Copy link
Contributor Author

J0anJosep commented Jul 1, 2024

@J0anJosep a few questions regarding some symbols though. The game doesn't have some of the used symbols in the translation strings and I'd like to ask you about them and what they mean so they can be added to the game.

In this file, what is the · symbol used for and how should it be represented in-game?

As for , « and ò, similar characters already exist and can be added no problem!

It is a middle dot: https://en.wikipedia.org/wiki/Interpunct#Catalan
It looks exactly as it is shown on GitHub.
If you can't add it, I could replace it with a simple dot ".", but it won't look good.

@J0anJosep
Copy link
Contributor Author

Another question. The translations for "off" ("desactivat/da") and "on" ("activat/da") are too long when viewed in-game and cause issues. Can it be written a bit shorter?

image image

Best case solution should fit inside this small button, if it can't that's fine, but it would be great to be close image

I will update the PR. "on/off" -> "sí/no". A simple "yes/no" will do the trick.

@SKPG-Tech
Copy link
Member

I added the special interpunct symbol, how does this look?
image

@J0anJosep
Copy link
Contributor Author

J0anJosep commented Jul 1, 2024

I added the special interpunct symbol, how does this look?

It looks perfect.

I have fixed a typo and changed the "on/off" translation.
If you need something more, just let me know.

Thank you very much!

@SKPG-Tech
Copy link
Member

I think that is all!

Thank you for translating the game into Catalan. You can check this repo out again in a few weeks for new strings to change (we don't roll new strings that often).
You can also optionally join our Discord server and we can directly remind people there. People who translate get a special role in the server so we can mention them!

You can expect the language to be in the game in a few weeks. Take care!

@SKPG-Tech SKPG-Tech merged commit 3eb2c70 into pewpewlive:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants