-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
works with sequences sharing same ids #119
base: master
Are you sure you want to change the base?
Conversation
Just looking at the code I don't understand the goal here - do you have a simplified example with the before/after behaviour? |
Of course. I had updated the tests accordingly. before this PR, with this kind of file:
the result:
now the result file is:
We often have this case, as we fetch sequences from various sources or people and try to merge them. Is this clear for you? |
The failed tests are not related to this PR, right? |
This is input query files with repeated identifiers? Repeated entries with the same identifier and sequence are one thing, repeated identifiers with different sequence are another. Personally I would make these an error condition - they cause too many problems downstream. |
The tool's master branch is failing on TravisCI against the Galaxy dev branch, see #120 |
you're right, the output is not yet perfect in this case:
the output was:
with this PR it's now (and not good either...):
|
@peterjc This new version works for what I was needed. I let you review the code and merge if you want. Thank you for your comments. |
a need that pop-up today from one of my colleague.