Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of namespace selection using wildcards #12

Merged
merged 7 commits into from
Sep 29, 2024

Conversation

naxvog
Copy link
Contributor

@naxvog naxvog commented Mar 5, 2024

As discussed in pestphp/pest#1072 and pestphp/pest#728 this PR allows the usage of wildcards in namespace selection.

This is useful if a module/domain architecture needs to be tested.

Tried to include globstar too but unfortunately symfony finder, as far as I know, does not support it.

@jambonfarci
Copy link

Is this PR still active ?
There are no assignees.

@naxvog naxvog changed the base branch from 2.x to 3.x September 27, 2024 17:11
@naxvog
Copy link
Contributor Author

naxvog commented Sep 27, 2024

I will fix the merge conflicts in the coming days.
However, to be frank, after 7 months without any sign from the maintainers I am pessimistic about this finding its way into pest.

@clementbirkle
Copy link

@nunomaduro this PR seems useful for several users. Could you approve it please? Thank you in advance 🙏

@nunomaduro nunomaduro merged commit be0551f into pestphp:3.x Sep 29, 2024
0 of 2 checks passed
nunomaduro added a commit that referenced this pull request Sep 29, 2024
This reverts commit be0551f, reversing
changes made to 0a27e55.
@nunomaduro
Copy link
Member

had to revert, because this test was failing:

arch()->expect('*')->toUseStrictTypes();

@naxvog
Copy link
Contributor Author

naxvog commented Sep 30, 2024

had to revert, because this test was failing:

arch()->expect('*')->toUseStrictTypes();

Sadly I could not find the test in question but added the one you mentioned anyway and the code passed the test.
However, I got the following failing test: Arch:base with the following message:

Expecting 'Pest\Arch' to only use 'dd, dump, expect, test, Pest, PHPUnit\Architecture, Symfony\Component\Finder\Finder, PhpParser\Node, Whoops\Exception\Frame'. However, it also uses 'PhpParser\Node'.

That being said I corrected the Stan issue detected after the merge of #12 and opened #16 to reflect the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants