display: Create Interfaces for text displays #42
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
- Coverage 97.9% 93.7% -4.2%
=======================================
Files 33 34 +1
Lines 3760 3930 +170
=======================================
+ Hits 3680 3681 +1
- Misses 75 244 +169
Partials 5 5 ☔ View full report in Codecov by Sentry. |
| // routines. This doesn't test brightness or contrast to avoid EEPROM wear | ||
| // issues. | ||
| func TestTextDisplay(dev display.TextDisplay, interactive bool) []error { | ||
| result := make([]error, 0) |
There was a problem hiding this comment.
var result []error will save an unnecessary memory allocation
| result := make([]error, 0) | ||
| var err error | ||
|
|
||
| pauseTime := time.Millisecond |
There was a problem hiding this comment.
I'd vote for not sleep at all when not interactive. These 1ms can add up quickly over time. Making it an argument would probably be nice, then: interfactive := pauseTime != 0
| WriteString(text string) (n int, err error) | ||
| } | ||
|
|
||
| type Intensity int |
There was a problem hiding this comment.
What's the expected valid range for the value? Is it worth standardizing or is it better to leave the range to be device-specific? I don't have an opinion.
This creates a set of interfaces for use by text oriented displays like LCDs. Ultimately, I'm planning on adding multiple backpacks for hd44780, the Sparkfun SerLCD, MatrixOrbital LK204-7T, Adafruit USB LCD backpack (compatible w/ MatrixOrbital), and an SSH1106 OLED.
The arch for the backpacks will be a backpack that accepts a gpio.Group(). Then, I'll have implementations (MCP23008, 8574T, gpioioctl.LineSet, and sets of GPIO pins.