Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag for --client to provide path to kubectl #811

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from
Open

Add flag for --client to provide path to kubectl #811

wants to merge 3 commits into from

Conversation

cshiv
Copy link
Contributor

@cshiv cshiv commented Apr 29, 2024

  • The contributed code is licensed under GPL v2.0
  • Contributor Licence Agreement (CLA) is signed
  • util/update-modules has been ran
  • Documentation updated
  • Test suite update

This is useful for clients like openshift etc

@cshiv cshiv requested review from ihanick and egegunes April 29, 2024 13:39
svetasmirnova
svetasmirnova requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@svetasmirnova svetasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetasmirnova svetasmirnova svetasmirnova requested changes

@ihanick ihanick Awaiting requested review from ihanick

@egegunes egegunes Awaiting requested review from egegunes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cshiv @svetasmirnova