-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1075 use controller runtime builder #1692
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
….com:percona/percona-server-mongodb-operator into K8SPSMDB-1075_use_controller_runtime_builder
return builder.ControllerManagedBy(mgr). | ||
For(&psmdbv1.PerconaServerMongoDBRestore{}). | ||
Named("psmdbrestore-controller"). | ||
WatchesRawSource( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we use WatchesRawSource
instead of Watches
? (there might be a legitimate reason, i'm just asking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can help me with it. I got errors when I try to use watches like this. @egegunes
Watches(
&source.Kind{Type: &corev1.Pod{}},
commit: 25a6a8b |
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Use controller runtime builder to configure controllers
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability