EVEREST-1672 | Unmarshalling proto response should discard unknown fields #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
michal-kralik
approved these changes
Nov 19, 2024
mayankshah1607
added a commit
that referenced
this pull request
Nov 19, 2024
…elds (#844) * fix Unmarshal Signed-off-by: Mayank Shah <[email protected]> * linting Signed-off-by: Mayank Shah <[email protected]> --------- Signed-off-by: Mayank Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New fields may be added to the VS API response message. Since Everest is compiled and shipped with a specific version of the VS package, when new fields are added to the response, it leads to error which causes upgrades to stop working.
By setting
DiscardUnknown=truein the Unmarshal options, it ignores unknown fields