build: add nodejs dep to flake env #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was always required, but was omitted in the flake env, causing `node` from system PATH to be used. It's more explicit to track a compatible version, so that `just dev` works out of the box for nix users.
|
Visit the preview URL for this PR (updated for commit ca976bd): https://penumbra-guide--pr48-add-nodejs-to-nix-en-jvl1y852.web.app (expires Fri, 27 Dec 2024 19:36:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c64218fe717b75c9724a23946df883a1adf10faa |
|
Self-merging because tiny dev-env commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always required, but was omitted in the flake env, causing
nodefrom system PATH to be used. It's more explicit to track a compatible version, so thatjust devworks out of the box for nix users.