Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Urgent Notif (iOS) #333

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add Urgent Notif (iOS) #333

merged 2 commits into from
Nov 19, 2024

Conversation

vcai122
Copy link
Contributor

@vcai122 vcai122 commented Nov 19, 2024

ex:
{'aps': {'alert': {'title': 'a', 'body': 'b'}, 'badge': 0, 'sound': 'default', 'mutable-content': 1, 'interruption-level': 'time-sensitive'}}

Copy link

sentry-io bot commented Nov 19, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: backend/user/notifications.py

Function Unhandled Issue
send_payload AttributeError: 'IOSNotificationWrapper' object has no attribute 'client' notifications....
Event Count: 6

Did you find this useful? React with a 👍 or 👎

@vcai122 vcai122 requested a review from anli5005 November 19, 2024 06:26
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.29%. Comparing base (73dc150) to head (e18f4c6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
backend/user/notifications.py 55.55% 8 Missing ⚠️
backend/user/views.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   88.46%   88.29%   -0.18%     
==========================================
  Files          67       67              
  Lines        2766     2776      +10     
==========================================
+ Hits         2447     2451       +4     
- Misses        319      325       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@anli5005 anli5005 merged commit 97387cd into master Nov 19, 2024
7 of 9 checks passed
@anli5005 anli5005 deleted the interruption-level-ios branch November 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants