Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Dining #230

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Cache Dining #230

merged 6 commits into from
Dec 1, 2023

Conversation

tuneerroy
Copy link
Contributor

@tuneerroy tuneerroy commented Dec 1, 2023

  • Cache dining

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01d1035) 89.82% compared to head (72fa4c6) 89.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   89.82%   89.87%   +0.04%     
==========================================
  Files          59       59              
  Lines        2536     2547      +11     
==========================================
+ Hits         2278     2289      +11     
  Misses        258      258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@judtinzhang judtinzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tuneer!

@tuneerroy tuneerroy merged commit 2f751aa into master Dec 1, 2023
9 checks passed
@tuneerroy tuneerroy deleted the cache-dining branch December 1, 2023 23:29
Copy link

sentry-io bot commented Dec 2, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ConnectionError: Error 111 connecting to penn-mobile-redis:6379. Connection refused. /api/dining/preferences/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants