Update to Polkadot SDK 1.6.0 #510
Conversation
ebma
changed the title
… compile for benchmarks
| @@ -468,8 +475,9 @@ impl pallet_balances::Config for Runtime { | |||
| type ReserveIdentifier = ReserveIdentifier; | |||
| type FreezeIdentifier = (); | |||
| type MaxFreezes = (); | |||
| type MaxHolds = ConstU32<1>; | |||
| type MaxHolds = ConstU32<2>; | |||
There was a problem hiding this comment.
Otherwise, we get an error MaxHolds should be greater than or equal to the number of hold reasons: 1 < 2, which is an internal check of the pallet.
Apparently the RuntimeHoldReason has 2 variants.
| @@ -719,6 +745,7 @@ parameter_types! { | |||
| pub const Burn: Permill = Permill::from_percent(0); | |||
| pub const TreasuryPalletId: PalletId = PalletId(*b"py/trsry"); | |||
| pub const MaxApprovals: u32 = 100; | |||
| pub const PayoutSpendPeriod: BlockNumber = 30 * DAYS; | |||
There was a problem hiding this comment.
I selected this arbitrarily. We might want to change.
| @@ -1005,6 +1042,8 @@ parameter_types! { | |||
| pub const MaxSubAccounts: u32 = 100; | |||
| pub const MaxAdditionalFields: u32 = 100; | |||
| pub const MaxRegistrars: u32 = 20; | |||
| pub const ByteDeposit: Balance = MILLIUNIT; | |||
There was a problem hiding this comment.
Also arbitrary and we may tweak to our business req.
| } | ||
|
|
||
| impl cumulus_pallet_dmp_queue::Config for Runtime { | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type XcmExecutor = XcmExecutor<XcmConfig>; | ||
| type ExecuteOverweightOrigin = EnsureRoot<AccountId>; | ||
| type DmpSink = frame_support::traits::EnqueueWithOrigin<MessageQueue, RelayOrigin>; |
There was a problem hiding this comment.
The pallet is deprecated, but we keep it to until it drains it's messages (to the replacement), assuming there are some after the update.
More info on the original PR.
| } | ||
|
|
||
| use parachains_common::message_queue::NarrowOriginToSibling; | ||
| impl pallet_message_queue::Config for Runtime { |
There was a problem hiding this comment.
This general queue pallet can work as dmp, xcmp, etc. We use it now as a replacement for the deprecated dmp_queue pallet.
gianfra-t
changed the title
|
@gianfra-t can you please also configure and perform a benchmark for the parachain-staking pallet? I saw just now that we are still using the default weights that were measured on a different parachain, see here. Instead we should measure different weights specific to each of our runtimes as some of the weights take into account constants which can differ for each of them. |
| @@ -24,7 +24,7 @@ | |||
| // --repeat | |||
| // 5 | |||
There was a problem hiding this comment.
Maybe we should adhere to the 'best practices' used in the docs for benchmarking and have it repeat not 5 but 20 times.
There was a problem hiding this comment.
Yes I changed it because it takes ages with 20 times. It already takes like 30 minutes with 5. And then I remembered that was the reason we disabled it from the script to run all benchmarks.
TODO
cargo checkdoes not work yet.try-runtimeCLI tests, to verify the storage version updates.pendulum-chain.Important Note
Package
runtime-integration-testswill not be updated on this PR, as it requires further dependency refactor that potentially consist of moving all polkadot dependencies to it'scrates-iodefinition (mostly due to the removal ofasset-hubruntimes frompolkadot-sdk).Closes #505.