Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move baseimage from Node.js 10 to mainline (Node.js 12) #4

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

orangejulius
Copy link
Member

The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between node-postal and Node.js 12.

We are now using a Node.js 12 compatible fork of the node-postal library, so we can now bring the libpostal baseimage back to parity with the other Docker images.

This will reduce complexity, maintenance times, and download sizes for Pelias containers.

Connects pelias/interpolation#245
Connects pelias/pelias#800

The libpostal baseimage has historically stayed on the Node.js 10 branch
of the Pelias base image due to incompatibility between [node-postal and
Node.js 12](openvenues/node-postal#24).

We are now using a Node.js 12 compatible fork of the `node-postal`
libary, so we can now bring the libpostal baseimage back to parity with
the other Docker images.

This will reduce complexity, maintenance times, and download sizes for
Pelias containers.

Connects pelias/interpolation#245
Connects pelias/pelias#800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant