if country_gid exists, remove empire fields #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dianashk
reviewed
Oct 9, 2017
There was a problem hiding this comment.
Instead of removing the properties, I'd consider using the predicate in geojsonify_place_details. It can be updated to look at the input params and the record being processed to decide if the property should be displayed to the end-user.
trescube
force-pushed
the
remove-empire-when-country-exists
branch
from
9bcc78b
to
e4e8d9b
Compare
dianashk
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Kelso, empire fields shouldn't be available if there's a country.
See pelias/placeholder#54