Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modern PHP version and some improvements #6

Merged
merged 19 commits into from
Nov 7, 2023

Conversation

kudashevs
Copy link
Contributor

@kudashevs kudashevs commented Nov 6, 2023

Hello,

We were using your scaffolding during yesterday's Day of Coderetreat. Thank you very much for make this scaffolding public 🙏

During the Day of Coderetreat I had some issues with different languages. So, I would like to propose some small changes to the scaffolding:

  • add .editorconfig file to maintain consistent coding styles (it is very flexible, for example javascript and typesript folders are going to use different coding styles for the same file extensions)
  • update the PHP version to use composer manager (but without namespaces, to keep the consistency with other languages - I noticed that none of the languages uses namespaces, except probably Golang)
  • update the Typescript version and bump dependencies (but not for the latest ones)
  • reorder ci.yml in a way that it follows the order of folders (it looks more readable for me)

If some of the changes are not appropriate let me please know. I'm going to divide this PR into small pieces.

@kudashevs kudashevs changed the title Add modern PHP version and some improvements Add a modern PHP version and some improvements Nov 6, 2023
@evanepio
Copy link
Member

evanepio commented Nov 7, 2023

Thank you!

@evanepio evanepio merged commit 7f8c4a5 into peidevs:main Nov 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants